decouple BufferedRuntimeExecutor from various targets#44196
Closed
philIip wants to merge 1 commit intofacebook:mainfrom
Closed
decouple BufferedRuntimeExecutor from various targets#44196philIip wants to merge 1 commit intofacebook:mainfrom
philIip wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [Internal] BufferedRuntimeExecutor is unnecessarily coupled with these other targets (React-runtime, React-cxxreact), break that dependency so we can modularize this file Reviewed By: realsoelynn Differential Revision: D56382644
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56382644 |
Base commit: 8e4b7fb |
Contributor
|
This pull request has been merged in d59de54. |
|
This pull request was successfully merged by @philIip in d59de54. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
Summary: Pull Request resolved: facebook#44196 Changelog: [Internal] BufferedRuntimeExecutor is unnecessarily coupled with these other targets (React-runtime, React-cxxreact), break that dependency so we can modularize this file Reviewed By: realsoelynn Differential Revision: D56382644 fbshipit-source-id: ed9725fbddcda04b73c583d927351440b4fc3328
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44196 Changelog: [Internal] BufferedRuntimeExecutor is unnecessarily coupled with these other targets (React-runtime, React-cxxreact), break that dependency so we can modularize this file Reviewed By: realsoelynn Differential Revision: D56382644 fbshipit-source-id: ed9725fbddcda04b73c583d927351440b4fc3328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
BufferedRuntimeExecutor is unnecessarily coupled with these other targets (React-runtime, React-cxxreact), break that dependency so we can modularize this file
Reviewed By: realsoelynn
Differential Revision: D56382644