Remove deprecated measureLayoutRelativeToParent of UIManagerModule#44452
Closed
arushikesarwani94 wants to merge 1 commit intofacebook:mainfrom
Closed
Remove deprecated measureLayoutRelativeToParent of UIManagerModule#44452arushikesarwani94 wants to merge 1 commit intofacebook:mainfrom
arushikesarwani94 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: `measureLayoutRelativeToParent` was deprecated 5 years ago in D16471845 and doesn't have [JS usages](https://fburl.com/code/tgwon7nb) Hence deleting this for 0.75 Release. This will simplify the backwards compatibility of UIManagerModule Changelog: [Android][Removed] Delete UIManagerModule.measureLayoutRelativeToParent() Differential Revision: D57069921
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57069921 |
Base commit: be09d12 |
arushikesarwani94
changed the title
Contributor
|
This pull request has been merged in 958f8e2. |
|
This pull request was successfully merged by @arushikesarwani94 in 958f8e2. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…acebook#44452) Summary: Pull Request resolved: facebook#44452 `measureLayoutRelativeToParent` was deprecated 5 years ago in D16471845 and doesn't have [JS usages](https://fburl.com/code/tgwon7nb) For the JS exposed UIManager API for measureLayoutRelativeToParent is through [UIImplementation.measureLayoutRelativeToParent()](https://www.internalfb.com/code/fbsource/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java?lines=804-815) Hence deleting this for 0.75 Release. This will simplify the backwards compatibility of UIManagerModule Changelog: [Android][Removed] Delete UIManagerModule.measureLayoutRelativeToParent() Reviewed By: javache Differential Revision: D57069921 fbshipit-source-id: 9f871424a39caf3cbeaa5570c7e101a714c11aa6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
measureLayoutRelativeToParentwas deprecated 5 years ago in D16471845 and doesn't have JS usagesHence deleting this for 0.75 Release. This will simplify the backwards compatibility of UIManagerModule
Changelog:
[Android][Removed] Remove deprecated UIManagerModule.measureLayoutRelativeToParent()
Differential Revision: D57069921