Use hasteModuleName for C++ Turbo Module enums#44631
Closed
christophpurrer wants to merge 2 commits intofacebook:mainfrom
Closed
Use hasteModuleName for C++ Turbo Module enums#44631christophpurrer wants to merge 2 commits intofacebook:mainfrom
christophpurrer wants to merge 2 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57602082 |
Base commit: 95de14d |
christophpurrer
force-pushed
the
export-D57602082
branch
from
b0e7ae6 to
a36f0fb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57602082 |
christophpurrer
force-pushed
the
export-D57602082
branch
from
a36f0fb to
d5d4f17
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57602082 |
christophpurrer
force-pushed
the
export-D57602082
branch
from
d5d4f17 to
4c2d508
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57602082 |
christophpurrer
force-pushed
the
export-D57602082
branch
from
4c2d508 to
2ff1429
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57602082 |
christophpurrer
force-pushed
the
export-D57602082
branch
from
2ff1429 to
95ec19e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57602082 |
christophpurrer
force-pushed
the
export-D57602082
branch
from
95ec19e to
1f6a217
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57602082 |
…44630) Summary: Changelog: [General][Breaking] Use hasteModuleName for C++ Turbo Module structs This changes the names of C++ Turbo Modules structs to use the `hasteModuleName`. Example: `NativeMyAbcModule.js` with this spec: ``` export type ValueStruct = { x: number, y: string, z: ObjectStruct, }; export interface Spec extends TurboModule { +getValueStruct: () => ValueStruct } export default (TurboModuleRegistry.get<Spec>('MyAbcModuleCxx'): ?Spec); ``` Before now we generated a base C++ struct with the name: ``` MyAbcModuleCxxValueStruct ^^^ ``` Now the generate name is: ``` NativeMyAbcModuleValueStruct ^^^^^^ ``` ## Changes: - No `Cxx` injected anymore - Ensure base struct is `Native` prefixed (all RN JS TM specs start with it) ## Why? - The `Cxx` extension is a temporary hint to react-native-codegen to enable extra capabilities and might disappear eventually - The C++ base struct name should be 'stable' - The name of the exported TM JS spec `TurboModuleRegistry.get<Spec>(...)` is abritrary, the hasteName is not - The name of the RN JS TM spec must start with `Native` which better guarantees a consistent naming scheme for these generated base class - The C++ Turbo Module base class has now the same prefix as the generated structs - `NativeMyAbcModule` for the example above Reviewed By: cipolleschi Differential Revision: D57599257
Summary: Changelog: [General][Breaking] Use hasteModuleName for C++ Turbo Module enums This is a follow up to facebook#44630 This changes the names of C++ Turbo Modules enums to use the `hasteModuleName`. Example: `NativeMyAbcModule.js` with this spec: ``` export enum EnumNone { NA, NB, } export interface Spec extends TurboModule { +getStrEnum: (arg: EnumNone) => EnumStr;t } export default (TurboModuleRegistry.get<Spec>('MyAbcModuleCxx'): ?Spec); ``` Before now we generated a base C++ struct with the name: ``` MyAbcModuleCxxEnumNone ^^^ ``` Now the generate name is: ``` NativeMyAbcModuleEnumNone ^^^^^^ ``` ## Changes: - No `Cxx` injected anymore - Ensure base struct is `Native` prefixed (all RN JS TM specs start with it) Reviewed By: cipolleschi Differential Revision: D57602082
christophpurrer
force-pushed
the
export-D57602082
branch
from
1f6a217 to
dee5cab
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57602082 |
christophpurrer
force-pushed
the
export-D57602082
branch
from
dee5cab to
cd78c8d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57602082 |
Contributor
|
This pull request has been merged in b7fc586. |
|
This pull request was successfully merged by @christophpurrer in b7fc586. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44631 Changelog: [General][Breaking] Use hasteModuleName for C++ Turbo Module enums This is a follow up to facebook#44630 This changes the names of C++ Turbo Modules enums to use the `hasteModuleName`. Example: `NativeMyAbcModule.js` with this spec: ``` export enum EnumNone { NA, NB, } export interface Spec extends TurboModule { +getStrEnum: (arg: EnumNone) => EnumStr;t } export default (TurboModuleRegistry.get<Spec>('MyAbcModuleCxx'): ?Spec); ``` Before now we generated a base C++ struct with the name: ``` MyAbcModuleCxxEnumNone ^^^ ``` Now the generate name is: ``` NativeMyAbcModuleEnumNone ^^^^^^ ``` ## Changes: - No `Cxx` injected anymore - Ensure base struct is `Native` prefixed (all RN JS TM specs start with it) Reviewed By: cipolleschi Differential Revision: D57602082 fbshipit-source-id: 9ebd68b8059dfbc6e2ec11065915cf049aa3cb0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal][Breaking] Use hasteModuleName for C++ Turbo Module enums
This is a follow up to #44630
This changes the names of C++ Turbo Modules enums to use the
hasteModuleName.Example:
NativeMyAbcModule.jswith this spec:Before now we generated a base C++ struct with the name:
Now the generate name is:
Changes:
Cxxinjected anymoreNativeprefixed (all RN JS TM specs start with it)Differential Revision: D57602082