Invert podspec to allowlist platform files#45734
Closed
rozele wants to merge 1 commit intofacebook:mainfrom
Closed
Invert podspec to allowlist platform files#45734rozele wants to merge 1 commit intofacebook:mainfrom
rozele wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60291091 |
Summary: Pull Request resolved: facebook#45734 Rather than enumerating all platforms the iOS podspec should not compile this inverts the source_files field to an allowlist for only files in platform/ios. ## Changelog [Internal] Differential Revision: D60291091
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60291091 |
Contributor
|
This pull request has been merged in 838d26d. |
Collaborator
|
This pull request was successfully merged by @rozele in 838d26d When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been reverted by cf9bad0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Rather than enumerating all platforms the iOS podspec should not compile this inverts the source_files field to an allowlist for only files in platform/ios.
Changelog
[Internal]
Differential Revision: D60291091