Disable react-in-jsx-scope rule in eslint config#46587
Disable react-in-jsx-scope rule in eslint config#46587matinzd wants to merge 2 commits intofacebook:mainfrom
Conversation
|
@cortinico Sorry for tagging you here. Any plans to merge this? |
|
Sorry for the delay.
Which warnings are you referring to @matinzd ? I haven't seen any warning related to what you're mentioning recently 🤔 |
|
ESLint will warn about importing React everywhere when you create a new React Native project that depends on this configuration. |
|
This is ready. @cipolleschi @cortinico Here is the repro: https://github.com/matinzd/react-in-jsx-warning-repro |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in ea56c43. |
|
This pull request was successfully merged by @matinzd in ea56c43 When will my fix make it into a release? | How to file a pick request? |
Summary: All newly generated react native apps are still showing warnings to use react in the jsx scope. That is not needed anymore as of react 18 with built-in jsx transform plugin. Reproduction: https://github.com/matinzd/react-in-jsx-warning-repro Run `npm run lint` in this repo. ## Changelog: [GENERAL] [FIXED] - Disable `react-in-jsx-scope` rule in eslint config Pull Request resolved: facebook/react-native#46587 Test Plan: Initiate a new template with community CLI and you should not see this warning anymore. Reviewed By: christophpurrer Differential Revision: D67394923 Pulled By: cipolleschi fbshipit-source-id: cfe8e44e33e1b3ae9fe17ca56dd3c7258b7bff69


Summary:
All newly generated react native apps are still showing warnings to use react in the jsx scope. That is not needed anymore as of react 18 with built-in jsx transform plugin.
Reproduction: https://github.com/matinzd/react-in-jsx-warning-repro
Run
npm run lintin this repo.Changelog:
[GENERAL] [FIXED] - Disable
react-in-jsx-scoperule in eslint configTest Plan:
Initiate a new template with community CLI and you should not see this warning anymore.