add support for iOS "Darker System Colors" (Increase Contrast) setting into AccessibilityInfo#46826
Closed
arielin3 wants to merge 1 commit intofacebook:mainfrom
Closed
add support for iOS "Darker System Colors" (Increase Contrast) setting into AccessibilityInfo#46826arielin3 wants to merge 1 commit intofacebook:mainfrom
arielin3 wants to merge 1 commit intofacebook:mainfrom
Conversation
…g into AccessibilityInfo Summary: This change adds `isDarkerSystemColorsEnabled()` to `AccessibilityInfo` to enable access to iOS's "Increase Contrast" setting option. It also adds a new event, `darkerSystemColorsChanged`, to enable listeners to subscribe to changes on this setting. ## Changelog [iOS][Added] - Added `isDarkerSystemColorsEnabled()` to `AccessibilityInfo` to read "Increase Contrast" setting value Differential Revision: D63880393
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63880393 |
Contributor
|
This pull request has been merged in af3bee6. |
Collaborator
|
This pull request was successfully merged by Ariel Lin in af3bee6 When will my fix make it into a release? | How to file a pick request? |
Saadnajmi
added a commit
to microsoft/react-native-macos
that referenced
this pull request
Mar 7, 2025
…OS (#2400) ## Summary: This PR attempts to solve two problems: 1. We have had a forked AccessibilityManager module for macOS for a while. In general, I prefer ifdefing rather than forking so that we get changes to the iOS code during merges. Let's combine the files. 2. I want to cleanup macOS's "highContrast" API in AccessibilityInfo so it can be upstreamed, so that RNW can follow it and we have a cross-platform way to get high contrast state. Luckily, the API we have for macOS can be ported to iOS, so I did that. Unluckily, someone already did that (see: facebook#46826 ) and used the iOS specific name "Darker system colors" instead of something like "increase contrast" or "high contrast". So I'll probably need to add my API upstream, deprecate that one, and then remove it in a future release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds
isDarkerSystemColorsEnabled()toAccessibilityInfoto enable access to iOS's "Increase Contrast" setting option. It also adds a new event,darkerSystemColorsChanged, to enable listeners to subscribe to changes on this setting.Changelog
[iOS][Added] - Added
isDarkerSystemColorsEnabled()toAccessibilityInfoto read "Increase Contrast" setting valueDifferential Revision: D63880393