[iOS] Fabric: Fixes AccessoryView not disappeared when pop up the page#47311
Closed
zhongwuzw wants to merge 2 commits intofacebook:mainfrom
Closed
[iOS] Fabric: Fixes AccessoryView not disappeared when pop up the page#47311zhongwuzw wants to merge 2 commits intofacebook:mainfrom
zhongwuzw wants to merge 2 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Member
|
Can you explain why this regressed in Fabric? Is there equivalent logic in the paper component? |
Contributor
Author
|
@javache I updated the code. I found the difference between them is we override the canBecomeFirstResponder of |
Contributor
Author
|
@javache Hi, can you please continue to review this? :) |
javache
approved these changes
Dec 19, 2024
Contributor
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Collaborator
|
This pull request was successfully merged by @zhongwuzw in dd303b2 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes AccessoryView not disappeared when page poped up. After page pop up, we can see a white view it the bottom of scrren.
Fixed:
https://github.com/user-attachments/assets/90305720-656b-4546-8730-53b89fee7a66
Before:
https://github.com/user-attachments/assets/8e4fbea3-1882-48f8-aa5f-0c4e9ddc4efd
Changelog:
[IOS] [FIXED] - Fabric: Fixes AccessoryView not disappeared when pop up the page
Test Plan:
RNTester InputAccessoryView example, repro steps please see the video above.