[Android] Modal: Setting resource-id from testID prop#48313
Closed
mateoguzmana wants to merge 2 commits intofacebook:mainfrom
Closed
[Android] Modal: Setting resource-id from testID prop#48313mateoguzmana wants to merge 2 commits intofacebook:mainfrom
resource-id from testID prop#48313mateoguzmana wants to merge 2 commits intofacebook:mainfrom
Conversation
Contributor
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@alanleedev merged this pull request in 52b6592. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 52b6592 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
@mateoguzmana Thanks for submitting the fix. |
Collaborator
Author
@alanleedev Thank you for taking the time to review and adjust this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up from #48271 and #48254, I noticed that the Modal component also doesn't map the
resource-idfrom thetestIDon Android. This PR addresses that.Changelog:
[ANDROID] [FIXED] - Modal: Setting
resource-idfromtestIDpropTest Plan:
Using Appium, check that the
testIDprop passed from JS is mapped asresource-idin the rendered view group of the Modal.Example of the code implementation in the RNTester Playground:
Output in Appium Inspector: