Rename SystraceSection to TraceSection#48383
Closed
rshest wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
rshest
force-pushed
the
export-D67621914
branch
from
a9fe3f6 to
83d3d76
Compare
rshest
force-pushed
the
export-D67621914
branch
from
83d3d76 to
dbcab35
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
rshest
force-pushed
the
export-D67621914
branch
from
dbcab35 to
87dbb99
Compare
rshest
force-pushed
the
export-D67621914
branch
from
87dbb99 to
9900208
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
rshest
force-pushed
the
export-D67621914
branch
from
9900208 to
71ddb92
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
rshest
force-pushed
the
export-D67621914
branch
from
71ddb92 to
fc40d9e
Compare
Summary: Pull Request resolved: facebook#48383 ## Changelog: [Internal] - This changes the name of `SystraceSection` class to `TraceSection`, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead). It changes all the internal callsites to the RN code code, and also adds a shim include, `<cxxreact/SystraceSection.h`, for backward compatibility with the external callers for now (which will be addressed separately). Reviewed By: javache Differential Revision: D67621914
rshest
force-pushed
the
export-D67621914
branch
from
fc40d9e to
307334d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
Contributor
|
This pull request has been merged in fcf3c8c. |
Collaborator
|
This pull request was successfully merged by @rshest in fcf3c8c When will my fix make it into a release? | How to file a pick request? |
CarSmallGuo
pushed a commit
to CarSmallGuo/ohos_react_native_new
that referenced
this pull request
Mar 25, 2026
Co-authored-by: Patryk Fryda<patryk.fryda@swmansion.com> # message auto-generated for no-merge-commit merge: !1751 merge 0.78-dev into 0.82 Update react-native to 0.78.3 Created-by: pafry Commit-by: Patryk Fryda Merged-by: huangyouhua Description: ## Why are these changes being made? There is ongoing effort to update react-native and RNOH to 0.82. This is the first step. **This PR should be merged to the new 0.82 branch.** ## Notable changes? - added minimumReleaseAge: 4320 to .pnpm-workspace, - bumped packages versions to RN 0.78.3 and react 19.0.0, - rebuilt hermes, - cleaned up the react-native.patch file PRs that forced changes in RNOH: - facebook/react-native#48000 – align new codegen with enum updates - facebook/react-native#48062 – pass tags instead of shadow views for Parent context - facebook/react-native#48383 – rename SystraceSection to TraceSection for tracing neutral - facebook/react-native#47247 – delete the legacy ReactNativeConfig the abstraction - facebook/react-native#48157 - drop the EnableFabricRendererExclusively Feature Flag - facebook/react-native#47723 – add ImageRequestParams to bundle image Request props - facebook/react-native#48127 – allow custom TextLayoutManager Implementations on C++ Platforms - facebook/react-native#48356 – rename ParsedError to ProcessedError for future error forwarding ## Changelog - updated react-native to 0.78.3 ## Test Plan - launch tester app, - run sequential and concurrent tests ## Checklist - [x] `pnpm verify` command has passed successfully. - [x] No failures occurred in automatic tests on the `CONCURRENT TESTER` page in the tester app. - [x] No failures occurred in automatic tests on the `SEQUENTIAL TESTER` page in the tester app. - [x] MR does not include a breaking change or a review has been requested from a Huawei reviewer. See merge request: openharmony-sig/ohos_react_native!1751
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
This changes the name of
SystraceSectionclass toTraceSection, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead).It changes all the internal callsites to the RN code code, and also adds a shim include,
<cxxreact/SystraceSection.h, for backward compatibility with the external callers for now (which will be addressed separately).Differential Revision: D67621914