fix: upgrade foojay-resolver-convention to 1.0.0#56210
Closed
TheNerdGuyLulu wants to merge 3 commits intofacebook:mainfrom
Closed
fix: upgrade foojay-resolver-convention to 1.0.0#56210TheNerdGuyLulu wants to merge 3 commits intofacebook:mainfrom
TheNerdGuyLulu wants to merge 3 commits intofacebook:mainfrom
Conversation
|
I believe it should be fixed in both places: |
Contributor
|
yes please |
Contributor
Author
|
@sschuberth @cortinico |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D98883905. |
|
@cortinico merged this pull request in 664acaf. |
Collaborator
|
This pull request was successfully merged by @TheNerdGuyLulu in 664acaf When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
foojay-resolver-convention's version 0.5.0 is not compatible with Gradle 9. (gradle/foojay-toolchains#151)
When trying to build for Android on React Native 0.8.2, we are presented with
Changelog:
Test Plan:
After making the change, the app build without problems.