Skip to content

fix: upgrade foojay-resolver-convention to 1.0.0#56210

Closed
TheNerdGuyLulu wants to merge 3 commits intofacebook:mainfrom
TheNerdGuyLulu:main
Closed

fix: upgrade foojay-resolver-convention to 1.0.0#56210
TheNerdGuyLulu wants to merge 3 commits intofacebook:mainfrom
TheNerdGuyLulu:main

Conversation

@TheNerdGuyLulu
Copy link
Copy Markdown
Contributor

Summary:

foojay-resolver-convention's version 0.5.0 is not compatible with Gradle 9. (gradle/foojay-toolchains#151)
When trying to build for Android on React Native 0.8.2, we are presented with

java.lang.NoSuchFieldError: Class org.gradle.jvm.toolchain.JvmVendorSpec does not have member field 'org.gradle.jvm.toolchain.JvmVendorSpec IBM_SEMERU'
	at org.gradle.toolchains.foojay.DistributionsKt.<clinit>(distributions.kt:16)
	at org.gradle.toolchains.foojay.FoojayApi.fetchDistributionsIfMissing(FoojayApi.kt:62)
	at org.gradle.toolchains.foojay.FoojayApi.match$foojay_resolver(FoojayApi.kt:49)
	at org.gradle.toolchains.foojay.FoojayApi.toLinks(FoojayApi.kt:41)

Changelog:

Test Plan:

After making the change, the app build without problems.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2026
@sschuberth
Copy link
Copy Markdown

I believe it should be fixed in both places:

packages/gradle-plugin/settings.gradle.kts:plugins { id("org.gradle.toolchains.foojay-resolver-convention").version("0.5.0") }
settings.gradle.kts:  id("org.gradle.toolchains.foojay-resolver-convention").version("0.5.0")

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 24, 2026
@cortinico
Copy link
Copy Markdown
Contributor

yes please

@TheNerdGuyLulu
Copy link
Copy Markdown
Contributor Author

@sschuberth
Thanks!

@cortinico
Change applied.

@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Mar 31, 2026

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D98883905.

@meta-codesync meta-codesync Bot closed this in 664acaf Mar 31, 2026
@facebook-github-tools facebook-github-tools Bot added the Merged This PR has been merged. label Mar 31, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Mar 31, 2026

@cortinico merged this pull request in 664acaf.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @TheNerdGuyLulu in 664acaf

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants