Remove legacy Paper renderer shim cleanup from artifact commit workflow (#36297) (#56483)#56483
Closed
rubennorte wants to merge 2 commits intofacebook:mainfrom
Closed
Remove legacy Paper renderer shim cleanup from artifact commit workflow (#36297) (#56483)#56483rubennorte wants to merge 2 commits intofacebook:mainfrom
rubennorte wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101329586. |
Summary: Changelog: [internal] `ReactNativeType` is the type of the legacy renderer, which is being removed. This removes the references to it so the removal can land without Flow errors. Differential Revision: D101352959
…ow (facebook#36297) (facebook#56483) Summary: ## Summary PR facebook#36285 deleted the Paper (legacy) renderer, including the shim file `scripts/rollup/shims/react-native/ReactNative.js`. However, the `runtime_commit_artifacts` workflow still tries to `rm` this file after moving build artifacts into `compiled-rn/`. Since the file no longer exists in the build output, `rm` (without `-f`) fails and kills the entire step. This has caused **every run of the Commit Artifacts workflow to fail since facebook#36285 landed on April 16**, blocking both `builds/facebook-www` and `builds/facebook-fbsource` branches from receiving new build artifacts. This in turn blocks DiffTrain from syncing React changes into Meta's internal monorepo. DiffTrain build for [bf45a68dd35ed08860b6a70fed641dfe6d7d290d](facebook/react@bf45a68) Reviewed By: zeyap Differential Revision: D101329586
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D101329586
branch
from
4bf6ebe to
26d9780
Compare
|
This pull request has been merged in 2979663. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
PR #36285 deleted the Paper (legacy) renderer, including the shim file
scripts/rollup/shims/react-native/ReactNative.js. However, theruntime_commit_artifactsworkflow still tries tormthis file aftermoving build artifacts into
compiled-rn/. Since the file no longerexists in the build output,
rm(without-f) fails and kills theentire step.
This has caused every run of the Commit Artifacts workflow to fail
since #36285 landed on April 16, blocking both
builds/facebook-wwwand
builds/facebook-fbsourcebranches from receiving new buildartifacts. This in turn blocks DiffTrain from syncing React changes into
Meta's internal monorepo.
DiffTrain build for bf45a68dd35ed08860b6a70fed641dfe6d7d290d
Reviewed By: zeyap
Differential Revision: D101329586