Launch the packager with react-native run-android on Windows#7129
Closed
janicduplessis wants to merge 3 commits intofacebook:masterfrom
Closed
Launch the packager with react-native run-android on Windows#7129janicduplessis wants to merge 3 commits intofacebook:masterfrom
react-native run-android on Windows#7129janicduplessis wants to merge 3 commits intofacebook:masterfrom
Conversation
Contributor
|
By analyzing the blame information on this pull request, we identified @martinbigio and @jimthedev to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
@janicduplessis updated the pull request. |
Contributor
Author
|
@mkonicek Can anyone review Windows PRs? :o |
|
@janicduplessis updated the pull request. |
Contributor
|
Wow this is awesome!! The test plan looks good, can't run the code but trust you :) @facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ptmt
pushed a commit
to ptmt/react-native
that referenced
this pull request
May 9, 2016
Summary: Adds support for launching the packager in a new window on Windows. **Test plan (required)** Tested that the packager is launched in a completely independent process. This means that exiting the `react-native run-android` command should not close the packager window and it should exit properly when completed even if the packager window is still opened. Pretty much made sure it behaves exactly like on mac. Also tested that an error in the packager will not close the window immediately to show the error stack trace. Closes facebook#7129 Differential Revision: D3240628 Pulled By: mkonicek fb-gh-sync-id: 007582250536481d2b2376f9a201f8f415fc1080 fbshipit-source-id: 007582250536481d2b2376f9a201f8f415fc1080
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary: Adds support for launching the packager in a new window on Windows. **Test plan (required)** Tested that the packager is launched in a completely independent process. This means that exiting the `react-native run-android` command should not close the packager window and it should exit properly when completed even if the packager window is still opened. Pretty much made sure it behaves exactly like on mac. Also tested that an error in the packager will not close the window immediately to show the error stack trace. Closes facebook#7129 Differential Revision: D3240628 Pulled By: mkonicek fb-gh-sync-id: 007582250536481d2b2376f9a201f8f415fc1080 fbshipit-source-id: 007582250536481d2b2376f9a201f8f415fc1080
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: Adds support for launching the packager in a new window on Windows. **Test plan (required)** Tested that the packager is launched in a completely independent process. This means that exiting the `react-native run-android` command should not close the packager window and it should exit properly when completed even if the packager window is still opened. Pretty much made sure it behaves exactly like on mac. Also tested that an error in the packager will not close the window immediately to show the error stack trace. Closes facebook/react-native#7129 Differential Revision: D3240628 Pulled By: mkonicek fb-gh-sync-id: 007582250536481d2b2376f9a201f8f415fc1080 fbshipit-source-id: 007582250536481d2b2376f9a201f8f415fc1080
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Adds support for launching the packager in a new window on Windows. **Test plan (required)** Tested that the packager is launched in a completely independent process. This means that exiting the `react-native run-android` command should not close the packager window and it should exit properly when completed even if the packager window is still opened. Pretty much made sure it behaves exactly like on mac. Also tested that an error in the packager will not close the window immediately to show the error stack trace. Closes facebook/react-native#7129 Differential Revision: D3240628 Pulled By: mkonicek fb-gh-sync-id: 007582250536481d2b2376f9a201f8f415fc1080 fbshipit-source-id: 007582250536481d2b2376f9a201f8f415fc1080
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for launching the packager in a new window on Windows.
Test plan (required)
Tested that the packager is launched in a completely independent process. This means that exiting the
react-native run-androidcommand should not close the packager window and it should exit properly when completed even if the packager window is still opened. Pretty much made sure it behaves exactly like on mac.Also tested that an error in the packager will not close the window immediately to show the error stack trace.