Commit 5a73299
committed
refactor: resolve browser via env variables based on build rather than user agent (#27179)
Fixes #26911,
#26860.
Currently, we are parsing user agent string to determine which browser
is running the extension. This doesn't work well with custom user
agents, and sometimes when user turns on mobile dev mode in Firefox, we
stop resolving that this is a Firefox browser, extension starts to use
Chrome API's and fails to inject.
Changes:
Since we are building different extensions for all supported browsers
(Chrome, Firefox, Edge), we predefine env variables for browser
resolution, which are populated in a build step.
DiffTrain build for commit 2c4c847.1 parent 315042d commit 5a73299
7 files changed
Lines changed: 9 additions & 9 deletions
File tree
- compiled-rn/facebook-fbsource/xplat/js
- RKJSModules/vendor
- react-test-renderer/cjs
- react/cjs
- react-native-github/Libraries/Renderer
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23986 | 23986 | | |
23987 | 23987 | | |
23988 | 23988 | | |
23989 | | - | |
| 23989 | + | |
23990 | 23990 | | |
23991 | 23991 | | |
23992 | 23992 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8612 | 8612 | | |
8613 | 8613 | | |
8614 | 8614 | | |
8615 | | - | |
| 8615 | + | |
8616 | 8616 | | |
8617 | 8617 | | |
8618 | 8618 | | |
| |||
8643 | 8643 | | |
8644 | 8644 | | |
8645 | 8645 | | |
8646 | | - | |
| 8646 | + | |
8647 | 8647 | | |
8648 | 8648 | | |
8649 | 8649 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9038 | 9038 | | |
9039 | 9039 | | |
9040 | 9040 | | |
9041 | | - | |
| 9041 | + | |
9042 | 9042 | | |
9043 | 9043 | | |
9044 | 9044 | | |
| |||
9069 | 9069 | | |
9070 | 9070 | | |
9071 | 9071 | | |
9072 | | - | |
| 9072 | + | |
9073 | 9073 | | |
9074 | 9074 | | |
9075 | 9075 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
616 | 616 | | |
617 | 617 | | |
618 | 618 | | |
619 | | - | |
| 619 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
619 | 619 | | |
620 | 620 | | |
621 | 621 | | |
622 | | - | |
| 622 | + | |
623 | 623 | | |
624 | 624 | | |
625 | 625 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments