Skip to content

Commit 5a73299

Browse files
committed
refactor: resolve browser via env variables based on build rather than user agent (#27179)
Fixes #26911, #26860. Currently, we are parsing user agent string to determine which browser is running the extension. This doesn't work well with custom user agents, and sometimes when user turns on mobile dev mode in Firefox, we stop resolving that this is a Firefox browser, extension starts to use Chrome API's and fails to inject. Changes: Since we are building different extensions for all supported browsers (Chrome, Firefox, Edge), we predefine env variables for browser resolution, which are populated in a build step. DiffTrain build for commit 2c4c847.
1 parent 315042d commit 5a73299

7 files changed

Lines changed: 9 additions & 9 deletions

File tree

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23986,7 +23986,7 @@ function createFiberRoot(
2398623986
return root;
2398723987
}
2398823988

23989-
var ReactVersion = "18.3.0-canary-41e9c17a6-20230829";
23989+
var ReactVersion = "18.3.0-canary-2c4c84718-20230829";
2399023990

2399123991
// Might add PROFILE later.
2399223992

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8612,7 +8612,7 @@ var devToolsConfig$jscomp$inline_1027 = {
86128612
throw Error("TestRenderer does not support findFiberByHostInstance()");
86138613
},
86148614
bundleType: 0,
8615-
version: "18.3.0-canary-41e9c17a6-20230829",
8615+
version: "18.3.0-canary-2c4c84718-20230829",
86168616
rendererPackageName: "react-test-renderer"
86178617
};
86188618
var internals$jscomp$inline_1226 = {
@@ -8643,7 +8643,7 @@ var internals$jscomp$inline_1226 = {
86438643
scheduleRoot: null,
86448644
setRefreshHandler: null,
86458645
getCurrentFiber: null,
8646-
reconcilerVersion: "18.3.0-canary-41e9c17a6-20230829"
8646+
reconcilerVersion: "18.3.0-canary-2c4c84718-20230829"
86478647
};
86488648
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86498649
var hook$jscomp$inline_1227 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9038,7 +9038,7 @@ var devToolsConfig$jscomp$inline_1069 = {
90389038
throw Error("TestRenderer does not support findFiberByHostInstance()");
90399039
},
90409040
bundleType: 0,
9041-
version: "18.3.0-canary-41e9c17a6-20230829",
9041+
version: "18.3.0-canary-2c4c84718-20230829",
90429042
rendererPackageName: "react-test-renderer"
90439043
};
90449044
var internals$jscomp$inline_1267 = {
@@ -9069,7 +9069,7 @@ var internals$jscomp$inline_1267 = {
90699069
scheduleRoot: null,
90709070
setRefreshHandler: null,
90719071
getCurrentFiber: null,
9072-
reconcilerVersion: "18.3.0-canary-41e9c17a6-20230829"
9072+
reconcilerVersion: "18.3.0-canary-2c4c84718-20230829"
90739073
};
90749074
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90759075
var hook$jscomp$inline_1268 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-canary-41e9c17a6-20230829";
30+
var ReactVersion = "18.3.0-canary-2c4c84718-20230829";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -616,4 +616,4 @@ exports.useSyncExternalStore = function (
616616
exports.useTransition = function () {
617617
return ReactCurrentDispatcher.current.useTransition();
618618
};
619-
exports.version = "18.3.0-canary-41e9c17a6-20230829";
619+
exports.version = "18.3.0-canary-2c4c84718-20230829";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,7 @@ exports.useSyncExternalStore = function (
619619
exports.useTransition = function () {
620620
return ReactCurrentDispatcher.current.useTransition();
621621
};
622-
exports.version = "18.3.0-canary-41e9c17a6-20230829";
622+
exports.version = "18.3.0-canary-2c4c84718-20230829";
623623

624624
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
625625
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
41e9c17a69f819f20a29823a0acf18456c5ef4d2
1+
2c4c84718810bf3df411d599acc152d08208d35f

0 commit comments

Comments
 (0)