Skip to content

Remove ReactComponentTreeHook from internals#19032

Merged
sebmarkbage merged 1 commit intofacebook:masterfrom
sebmarkbage:rmfor17
May 28, 2020
Merged

Remove ReactComponentTreeHook from internals#19032
sebmarkbage merged 1 commit intofacebook:masterfrom
sebmarkbage:rmfor17

Conversation

@sebmarkbage
Copy link
Copy Markdown
Contributor

We don't really support mixing minor versions anymore anyway. But seems safe to remove in 17.

We don't really support mixing minor versions anymore anyway. But seems
safe to remove in 17.
@sebmarkbage sebmarkbage requested a review from gaearon May 28, 2020 03:05
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 28, 2020
@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb4eb08:

Sandbox Source
friendly-brown-mi44c Configuration

@sizebot
Copy link
Copy Markdown

sizebot commented May 28, 2020

Details of bundled changes.

Comparing: 43e59f2...eb4eb08

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js -0.4% -0.8% 112.64 KB 112.14 KB 27.39 KB 27.19 KB UMD_DEV
react-jsx-runtime.profiling.min.js 0.0% -0.5% 958 B 958 B 603 B 600 B NODE_PROFILING
react.production.min.js -0.1% -0.2% 12.5 KB 12.49 KB 4.88 KB 4.87 KB UMD_PROD
react-unstable-cache.profiling.min.js 0.0% -0.2% 866 B 866 B 562 B 561 B NODE_PROFILING
react-jsx-dev-runtime.development.js 0.0% -0.0% 36.03 KB 36.03 KB 10.45 KB 10.45 KB NODE_DEV
react-jsx-runtime.development.js 0.0% -0.0% 36.61 KB 36.61 KB 10.62 KB 10.62 KB NODE_DEV
react-jsx-runtime.production.min.js 0.0% -0.3% 959 B 959 B 603 B 601 B NODE_PROD
react.profiling.min.js -0.0% -0.1% 16.04 KB 16.03 KB 5.98 KB 5.97 KB UMD_PROFILING
react.development.js -0.3% -0.4% 73.68 KB 73.47 KB 19.62 KB 19.53 KB NODE_DEV
react.production.min.js 0.0% -0.0% 7.5 KB 7.5 KB 2.96 KB 2.95 KB NODE_PROD
React-dev.js -0.2% -0.4% 99.09 KB 98.88 KB 24.14 KB 24.05 KB FB_WWW_DEV
React-prod.js 0.0% -0.0% 17.64 KB 17.64 KB 4.58 KB 4.58 KB FB_WWW_PROD
React-profiling.js 0.0% -0.0% 17.64 KB 17.64 KB 4.58 KB 4.58 KB FB_WWW_PROFILING
react-unstable-cache.development.js 0.0% -0.2% 1.05 KB 1.05 KB 588 B 587 B NODE_DEV
react-unstable-cache.production.min.js 0.0% -0.2% 867 B 867 B 563 B 562 B NODE_PROD

React: size: -0.1%, gzip: -0.2%

Size changes (experimental)

Generated by 🚫 dangerJS against eb4eb08

@sizebot
Copy link
Copy Markdown

sizebot commented May 28, 2020

Details of bundled changes.

Comparing: 43e59f2...eb4eb08

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js -0.5% -0.8% 102.76 KB 102.27 KB 24.91 KB 24.71 KB UMD_DEV
react.production.min.js -0.1% -0.3% 11.39 KB 11.38 KB 4.55 KB 4.54 KB UMD_PROD
react-jsx-runtime.development.js 0.0% -0.0% 31.13 KB 31.13 KB 9.06 KB 9.05 KB NODE_DEV
react-jsx-runtime.production.min.js 0.0% -0.3% 946 B 946 B 595 B 593 B NODE_PROD
react-jsx-runtime.profiling.min.js 0.0% -0.3% 945 B 945 B 594 B 592 B NODE_PROFILING
react.profiling.min.js -0.0% -0.1% 14.9 KB 14.89 KB 5.63 KB 5.63 KB UMD_PROFILING
react.development.js -0.3% -0.5% 64.29 KB 64.08 KB 17.24 KB 17.15 KB NODE_DEV
react.production.min.js 0.0% -0.0% 6.32 KB 6.32 KB 2.62 KB 2.62 KB NODE_PROD
React-dev.js -0.2% -0.4% 100.09 KB 99.87 KB 24.33 KB 24.24 KB FB_WWW_DEV
React-prod.js 0.0% -0.0% 17.78 KB 17.78 KB 4.63 KB 4.63 KB FB_WWW_PROD
react-jsx-dev-runtime.development.js 0.0% -0.0% 30.54 KB 30.54 KB 8.88 KB 8.88 KB NODE_DEV
React-profiling.js 0.0% -0.0% 17.78 KB 17.78 KB 4.63 KB 4.63 KB FB_WWW_PROFILING
react-jsx-dev-runtime.profiling.min.js 0.0% -0.3% 439 B 439 B 312 B 311 B NODE_PROFILING

React: size: -0.1%, gzip: -0.3%

Size changes (stable)

Generated by 🚫 dangerJS against eb4eb08

@sebmarkbage sebmarkbage merged commit 6071486 into facebook:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants