Scheduling Profiler: Extract and test scroll state from horizontal pan and zoom view#19682
Merged
bvaughn merged 3 commits intofacebook:masterfrom Sep 3, 2020
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9cd6e4b:
|
taneliang
force-pushed
the
extract-scroll-state
branch
from
abb1462 to
9cd6e4b
Compare
Contributor
|
This is in my queue to review. I was on PTO last week though and I have a lot of catch up to do. I'll try to get to it sometime in the next couple of days. 😄 |
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
…n and zoom view (facebook#19682) * Extract reusable scroll logic from HorizontalPanAndZoomView * Change VerticalScrollView to use scrollState * Clarify test name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HorizontalPanAndZoomViewandVerticalScrollViewinto a bunch of functions.Also fixes this issue where zooming in/out results in offset jumps:
cc @bvaughn, @kartikcho
Test Plan