DevTools: Improve browser extension iframe support#19827
DevTools: Improve browser extension iframe support#19827bvaughn merged 10 commits intofacebook:masterfrom
Conversation
DevTools: Iframe support
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 554ea7e:
|
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
Thanks! This looks good.
| } | ||
|
|
||
| function isMainWindow(targetWindow: any): boolean { | ||
| return targetWindow.self === targetWindow.top; |
There was a problem hiding this comment.
Why window.self rather than just window?
There was a problem hiding this comment.
It is the same but self can work with worker(it is more flexible)
There was a problem hiding this comment.
Ok just wanted to confirm I wasn't missing anything. 😄
|
Thank you @bvaughn ! |
|
Looks like this change broke the development test harness. To repro:
I think I'm going to have to revert it for now. Any interest in looking back into it @omarsy? |
|
ok @bvaughn I'm looking it |
Co-authored-by: Joel DSouza <joel.dsouza@kapturecrm.com> Co-authored-by: Damien Maillard <damien.maillard@dailymotion.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>
…19827)" (facebook#19852) This reverts commit ec39a5e.
Co-authored-by: Joel DSouza <joel.dsouza@kapturecrm.com> Co-authored-by: Damien Maillard <damien.maillard@dailymotion.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>
…19827)" (facebook#19852) This reverts commit ec39a5e.
4 participants
Summary
This pull requests is intended to improve iframe support for devtools browser extensions(#18945), without add a code to pass the hook through from the parent.
Test Plan