Skip to content

Fix contradiction in the README.md#19897

Merged
bvaughn merged 2 commits intofacebook:masterfrom
dmtrKovalenko:patch-1
Sep 28, 2020
Merged

Fix contradiction in the README.md#19897
bvaughn merged 2 commits intofacebook:masterfrom
dmtrKovalenko:patch-1

Conversation

@dmtrKovalenko
Copy link
Copy Markdown
Contributor

Summary

Fix docs typo

Test Plan

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Sep 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d84dddc:

Sandbox Source
React Configuration

@sizebot
Copy link
Copy Markdown

sizebot commented Sep 24, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against d84dddc

@sizebot
Copy link
Copy Markdown

sizebot commented Sep 24, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against d84dddc

@bvaughn
Copy link
Copy Markdown
Contributor

bvaughn commented Sep 24, 2020

the backend must not be activated until after the frontend has been initialized

Can you elaborate on why you think this was a contradiction? I kind of thing the previous wording was a little clearer.

@dmtrKovalenko
Copy link
Copy Markdown
Contributor Author

dmtrKovalenko commented Sep 26, 2020

@bvaughn sorry for the long response.

Personally, I (as not a native speaker) found this confusing because the phrase until after is not using rarely and I googled this briefly and thought that it was a typo. But after some more deep googling I found that it means until the end of some period.

! No matter the meaning it is still a little bit confusing because the phrase has been initialized means the moment in the past when frontend was actually initialized – so we can use only until there. As far I understand after reading English forums the proper use of until after here would be "the backend must not be active until after frontend initialization" .

Anyway, feel free to close this issue. I am not a native speaker – so probably I don't understand everything, but this potentially can confuse somebody as well. (or not) :)

@bvaughn
Copy link
Copy Markdown
Contributor

bvaughn commented Sep 28, 2020

Thank you for elaborating.

I think the change in wording in this PR actually makes the README slightly less clear (from a native speaker's perspective) but maybe there is another change that could help both. What about?

The frontend and backend can be initialized in any order, but the backend must not be activated until the frontend initialization has completed. Because of this, the simplest sequence is:

@dmtrKovalenko
Copy link
Copy Markdown
Contributor Author

dmtrKovalenko commented Sep 28, 2020

I am not sure about this frontend has been initialization. I think this will be more simple and clear

-The frontend and backend can be initialized in any order, but the backend must not be activated until the frontend has been initialization has completed. Because of this, the simplest sequence is:
+ The frontend and backend can be initialized in any order, but the backend must not be activated until the frontend initialization has been completed. Because of this, the simplest sequence is:

@bvaughn
Copy link
Copy Markdown
Contributor

bvaughn commented Sep 28, 2020

Gah, I forgot to delete a "has been" in my previous suggestion. Sorry!

Comment thread packages/react-devtools-inline/README.md Outdated
@bvaughn
Copy link
Copy Markdown
Contributor

bvaughn commented Sep 28, 2020

If you think this is clearer for non-native speaker, then I don't object. I think it's as clear for native speakers. 👍

@bvaughn bvaughn merged commit 71bc8ac into facebook:master Sep 28, 2020
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants