Remove server side lower casing warning#21076
Closed
sebmarkbage wants to merge 1 commit intofacebook:masterfrom
Closed
Remove server side lower casing warning#21076sebmarkbage wants to merge 1 commit intofacebook:masterfrom
sebmarkbage wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
reviewed
Mar 24, 2021
gaearon
approved these changes
Mar 24, 2021
|
Comparing: fb8c191...e2130df Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Collaborator
|
I'm confused about CI failure. |
sebmarkbage
force-pushed
the
partialnamespace
branch
from
3a8aa44 to
32ce78c
Compare
sebmarkbage
force-pushed
the
partialnamespace
branch
from
32ce78c to
e2130df
Compare
Contributor
Author
|
Another thing this warning did differently was warn for custom elements but the client one doesn't do that. |
Contributor
Author
|
It's interesting because the runtime behavior is also different since the tag is lowerCased before we compare it to special cases like 'select' where as the client doesn't do that. That's why we have the warning in the first place, other than just consistency, it allows us to not apply special cases for different cases. |
Contributor
Author
|
Ugh. So there's one place namespace really matters in Fizz. We'd need to know what wrapper to use for segment containers if you suspend inside an SVG tree but the stream is streaming into a HTML root. Neither of these need to know the actual namespace though - unlike the client. Just what wrapper it needs to use. |
Contributor
Author
|
Abandoning this since I already implemented it in Fizz anyway. Fix for custom-elements is here #21156 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's the only thing (outside selected value which has its own complexities with suspense) that's contextual. It's not worth adding a host config at runtime for this. So I'm removing it for parity.
We have this warning on the client. We don't have other warnings like ancestor nesting on the server anyway. We can instead warn for those in the hydration phase if we need to.