fix[compiler playground]: Set source as the pre-change state in HIR diff#29957
Merged
poteto merged 3 commits intofacebook:mainfrom Jun 20, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 6b4646c...df682f8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Member
|
Thanks for the PR! I’ve never actually used the diff mode for the HIR panel, because there is nothing to diff against. Would you mind changing to just make the diff source empty for this panel? Diffing against the source doesn’t make sense since they’re such different representations. |
Contributor
Author
|
Thank you for reviewing the PR! I have updated it so that the HIR diff is no longer displayed. screenshot
|
Contributor
|
Looks good, thank you! |
This was referenced Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I have fixed an issue where the display of the HIR diff in the React Compiler Playground was incorrect. The HIR diff is supposed to show the pre-change state as the source, but currently, it is showing EnvironmentConfig as the pre-change state. This PR corrects this by setting the pre-change state to source instead of EnvironmentConfig.
How did you test this change?
before:
after: