Skip to content

[Flight] Add context for non null prototype error#30293

Merged
sebmarkbage merged 1 commit intofacebook:mainfrom
sebmarkbage:flighterrordevcontext
Jul 9, 2024
Merged

[Flight] Add context for non null prototype error#30293
sebmarkbage merged 1 commit intofacebook:mainfrom
sebmarkbage:flighterrordevcontext

Conversation

@sebmarkbage
Copy link
Copy Markdown
Contributor

@sebmarkbage sebmarkbage commented Jul 9, 2024

We already added this for other thrown errors, not just console.errors. There's a production form of this. We just missed adding this context.

Mainly the best context is the line number though which comes from owner stacks.

@sebmarkbage sebmarkbage requested a review from gnoff July 9, 2024 00:29
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 0:34am

Copy link
Copy Markdown
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants