Skip to content

[Fizz] Start initial work immediately#31079

Merged
gnoff merged 1 commit intofacebook:mainfrom
gnoff:fizz-start-work-immediately
Sep 26, 2024
Merged

[Fizz] Start initial work immediately#31079
gnoff merged 1 commit intofacebook:mainfrom
gnoff:fizz-start-work-immediately

Conversation

@gnoff
Copy link
Copy Markdown
Collaborator

@gnoff gnoff commented Sep 26, 2024

In a recent update we make Flight start working immediately rather than waitin for a new task. This commit updates fizz to have similar mechanics. We start the render in the currently running task but we do so in a microtask to avoid reentrancy. This aligns Fizz with Flight.

ref: #30961

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:47pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 26, 2024
@gnoff gnoff requested a review from sebmarkbage September 26, 2024 20:16
@react-sizebot
Copy link
Copy Markdown

react-sizebot commented Sep 26, 2024

Comparing: 60b1420f18e9473230f23f88fdc7b89fea3dbbfd...df89c1086b758a5ae45217c4203c8fe5fda972c3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 507.20 kB 507.20 kB = 90.80 kB 90.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.13 kB 512.13 kB = 91.52 kB 91.52 kB
facebook-www/ReactDOM-prod.classic.js = 603.73 kB 603.73 kB = 106.84 kB 106.84 kB
facebook-www/ReactDOM-prod.modern.js = 579.95 kB 579.95 kB = 102.92 kB 102.92 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 3ba5655

In a recent update we make Flight start working immediately rather than waitin for a new task. This commit updates fizz to have similar mechanics. We start the render in the currently running task but we do so in a microtask to avoid reentrancy. This aligns Fizz with Flight.
@gnoff gnoff force-pushed the fizz-start-work-immediately branch from 0ea35c5 to 3ba5655 Compare September 26, 2024 20:45
@gnoff gnoff merged commit 67fee58 into facebook:main Sep 26, 2024
@gnoff gnoff deleted the fizz-start-work-immediately branch September 26, 2024 20:51
github-actions Bot pushed a commit that referenced this pull request Sep 26, 2024
In a recent update we make Flight start working immediately rather than
waitin for a new task. This commit updates fizz to have similar
mechanics. We start the render in the currently running task but we do
so in a microtask to avoid reentrancy. This aligns Fizz with Flight.

ref: #30961

DiffTrain build for [67fee58](67fee58)
github-actions Bot pushed a commit that referenced this pull request Sep 26, 2024
In a recent update we make Flight start working immediately rather than
waitin for a new task. This commit updates fizz to have similar
mechanics. We start the render in the currently running task but we do
so in a microtask to avoid reentrancy. This aligns Fizz with Flight.

ref: #30961

DiffTrain build for [67fee58](67fee58)
gnoff added a commit to vercel/next.js that referenced this pull request Sep 27, 2024
**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-778e1ed2-20240926` to `19.0.0-rc-3edc000d-20240926`**

[diff
facebook/react@778e1ed2...3edc000d](facebook/react@778e1ed...3edc000)

<details>
<summary>React upstream changes</summary>

- facebook/react#31078
- facebook/react#31083
- facebook/react#31079
- facebook/react#31080
- facebook/react#31076
- facebook/react#31021
- facebook/react#31069
- facebook/react#31074
- facebook/react#31073
- facebook/react#31047
- facebook/react#31046
- facebook/react#31045
- facebook/react#31072
- facebook/react#30980
- facebook/react#30463
- facebook/react#30694
- facebook/react#31039
- facebook/react#31048
- facebook/react#31068

</details>

---------

Co-authored-by: Josh Story <story@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants