Skip to content

[DevTools] Remove markers from Suspense timeline#34357

Merged
eps1lon merged 1 commit intofacebook:mainfrom
eps1lon:sebbie/09-01-_devtools_remove_markers_from_timeline
Sep 2, 2025
Merged

[DevTools] Remove markers from Suspense timeline#34357
eps1lon merged 1 commit intofacebook:mainfrom
eps1lon:sebbie/09-01-_devtools_remove_markers_from_timeline

Conversation

@eps1lon
Copy link
Copy Markdown
Collaborator

@eps1lon eps1lon commented Sep 1, 2025

The marker were intended so that you can click on the "meaningful" milestones. But there's just too many in a sufficiently large app resulting in collapsed markers. We could make the input scrollable though for now I prefer having the whole timeline hoverable at once.

Maybe there's a better heuristic like "biggest N" boundaries instead. For now I added X / N display for orientation like we have in the Profiler tab.

Before
CleanShot 2025-09-01 at 16 27 15@2x
After:
CleanShot 2025-09-01 at 16 45 55@2x

@meta-cla meta-cla Bot added the CLA Signed label Sep 1, 2025
@github-actions github-actions Bot added the React Core Team Opened by a member of the React Core Team label Sep 1, 2025
@eps1lon eps1lon force-pushed the sebbie/09-01-_devtools_remove_markers_from_timeline branch from fb56151 to eefefc0 Compare September 1, 2025 14:46
@eps1lon eps1lon changed the title [DevTools] Fix inspected element scroll in Suspense tab [DevTools] Remove markers from timeline Sep 1, 2025
@eps1lon eps1lon changed the title [DevTools] Remove markers from timeline [DevTools] Remove markers from Suspense timeline Sep 1, 2025
@eps1lon eps1lon requested a review from hoxyq September 1, 2025 15:09
@eps1lon eps1lon marked this pull request as ready for review September 1, 2025 15:09
Copy link
Copy Markdown
Contributor

@hoxyq hoxyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the vertical alignment feels a bit off

@eps1lon
Copy link
Copy Markdown
Collaborator Author

eps1lon commented Sep 2, 2025

Yeah, it's aligned with the slider thumb but not track. The slider is just the default input[type="range"] but that's not the final version. Just gives me keyboard and pointer interactions out-of-the-box.

@eps1lon eps1lon merged commit 8e60cb7 into facebook:main Sep 2, 2025
244 checks passed
@eps1lon eps1lon deleted the sebbie/09-01-_devtools_remove_markers_from_timeline branch September 2, 2025 12:59
@sebmarkbage
Copy link
Copy Markdown
Contributor

Maybe just turn it into a big red box saying "You have too many boundaries. This is never good design.".

@sebmarkbage
Copy link
Copy Markdown
Contributor

Feels awkward to optimize for the case you shouldn't be in and where it becomes hard to use the tool for anything useful anyway.

Btw, are you filtering out on hasUniqueSuspenders yet? That seems like something that's needed as the first thing.

@sebmarkbage
Copy link
Copy Markdown
Contributor

Another milestone would be the change in environment. That was the only thing we intended originally to flag. E.g. "Prerender".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants