[DevTools] Remove markers from Suspense timeline#34357
Conversation
fb56151 to
eefefc0
Compare
hoxyq
left a comment
There was a problem hiding this comment.
nit: the vertical alignment feels a bit off
|
Yeah, it's aligned with the slider thumb but not track. The slider is just the default |
|
Maybe just turn it into a big red box saying "You have too many boundaries. This is never good design.". |
|
Feels awkward to optimize for the case you shouldn't be in and where it becomes hard to use the tool for anything useful anyway. Btw, are you filtering out on |
|
Another milestone would be the change in environment. That was the only thing we intended originally to flag. E.g. "Prerender". |
DiffTrain build for [8e60cb7](facebook@8e60cb7)
DiffTrain build for [8e60cb7](facebook@8e60cb7)
The marker were intended so that you can click on the "meaningful" milestones. But there's just too many in a sufficiently large app resulting in collapsed markers. We could make the input scrollable though for now I prefer having the whole timeline hoverable at once.
Maybe there's a better heuristic like "biggest N" boundaries instead. For now I added
X / Ndisplay for orientation like we have in the Profiler tab.Before


After: