Make React a peerDep of react-dom#5366
Merged
zpao merged 1 commit intofacebook:masterfrom Nov 2, 2015
Merged
Conversation
zpao
added a commit
to zpao/react
that referenced
this pull request
Nov 2, 2015
Make React a peerDep of react-dom (cherry picked from commit a82400f)
dilberx
pushed a commit
to dilberx/react
that referenced
this pull request
Apr 15, 2026
Make React a peerDep of react-dom (cherry picked from commit 7c11295)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is probably the right thing to do to avoid even more dependency hell. There's basically no point where you're using ReactDOM that you don't also need React. While we reach deeply, we should make sure there's only 1 version. This matches what we already do for the addons packages.
fixes #5282