fix(asgi.App): correctly pass params when using orjson.dumps#2102
Merged
vytas7 merged 6 commits intofalconry:masterfrom Aug 31, 2022
Merged
fix(asgi.App): correctly pass params when using orjson.dumps#2102vytas7 merged 6 commits intofalconry:masterfrom
orjson.dumps#2102vytas7 merged 6 commits intofalconry:masterfrom
Conversation
CaselIT
force-pushed
the
json_handler_fix
branch
from
c3c3c71 to
530584c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2102 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 62
Lines 6746 6746
Branches 1255 1255
=========================================
Hits 6746 6746
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vytas7
changed the title
orjson.dumps
vytas7
requested changes
Aug 30, 2022
Member
vytas7
left a comment
vytas7
left a comment
There was a problem hiding this comment.
LGTM except the newsfragment 👍
Member
Author
|
thanks for the update on the news fragment |
vytas7
added a commit
that referenced
this pull request
Nov 5, 2022
* fix: this change fixes an issue when using orjson as json serializer with asyncio * docs: improve newsfragment * test: ensure _serialize_async_b is also tested using the app * docs(newsfragments): capitalize JSON Co-authored-by: Vytautas Liuolia <vytautas.liuolia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Replace this text with a high-level summary of the changes included in this PR.
Related Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
#2100
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
docs/.docs/.versionadded,versionchanged, ordeprecateddirectives.docs/_newsfragments/, with the file name format{issue_number}.{fragment_type}.rst. (Runtowncrier --draftto ensure it renders correctly.)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.