Skip to content

fix(userspace/engine): replace invalid chars while JSON-encoding#3866

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/fix-json-output
May 4, 2026
Merged

fix(userspace/engine): replace invalid chars while JSON-encoding#3866
poiana merged 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/fix-json-output

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented Apr 30, 2026

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

This PR adds a second layer of sanitization in code encoding the output as JSON. The main sanitization issues should have been already addressed in libs (see falcosecurity/libs#2965): this second layer just ensures Falco doesn't crash if we missed something there.

I want to thank again https://github.com/naokato for discovering the issue and helping us with fixing it 🙏 .

Which issue(s) this PR fixes:

Related to falcosecurity/libs#2965

Fixes #

Special notes for your reviewer:

/milestone 0.44.0

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@github-actions
Copy link
Copy Markdown

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation Bot moved this from Todo to In progress in Falco Roadmap Apr 30, 2026
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ekoops
Copy link
Copy Markdown
Contributor Author

ekoops commented May 4, 2026

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

False positive.
/hold cancel

@poiana poiana merged commit 39e0420 into falcosecurity:master May 4, 2026
34 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Falco Roadmap May 4, 2026
@ekoops ekoops deleted the ekoops/fix-json-output branch May 5, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants