fastify-apollo has been merged into apollo-server

[dtex]

As of this PR, fastify-apollo is no longer a standalone module and the repo has been archived.

@nfishe Can you add a note on your repo also? It would be helpful for anyone who stumbles across it.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[mcollina]

Awesome! I'll merge this once that is released, is that ok?

https://www.npmjs.com/package/apollo-server-fastify is still 10 months old.

[delvedor]

I think we can leave the line in our documentation and update the url to the new repo :)

[dtex]

Is that ok?

Of course. I was just hoping to save someone the head-scratching that I just experienced. This PR doesn't really help given that

https://www.npmjs.com/package/apollo-server-fastify is still 10 months old.

Oh... well... darn. I guess we are in some kind of valley between fastify-apollo and apollo-server-fastify.

leave the line in our documentation and update the url

@delvedor I think that's fine as long as there is an explanatory note. It would be confusing if the link text says you're going one place and then the link goes to another. However, given Mateo's note, things are a little more complicated than I understood them to be. We may as well close this rather than leave it open indefinitely.

[delvedor]

@dtex what I mean is, instead of removing the line, just update it with the new plugin :)

[dtex]

@delvedor Oh, gotchya. Yes, once it goes live that is the right thing to do.

[mannyluvstacos]

Hi, @dtex and all!

It would be helpful for anyone who stumbles across it.

I was one of those people that stumbled upon the fastify-apollo module and saw that it was archived and also saw: Integrate apollo-fastify plugin #626 #1013.

For my understanding, there is a PR in flight to create a apollo-server-fastify and fastify-apollo is to no longer be used?

I look forward to hearing back!

-Manny

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dtex]

Just an update. There is a new PR for the support we need in Apollo:

apollographql/apollo-server#1760

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[delvedor]

What's the status on this?

[darkgl0w]

Since the release of apollo-server@2.4.2, fastify support has officially landed (related PR: apollographql/apollo-server#2280)

I think this PR just needs an update to reference the official package (by pointing to this link : https://github.com/apollographql/apollo-server/tree/master/packages/apollo-server-fastify and referencing the package as apollo-server-fastify) ^^

Edit: there is a related PR running here : #1156

[delvedor]

@darkgl0w would you like to open a new pr with the correct link?

[dtex]

Thank you @darkgl0w Closing this in deference to #1524

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.