Skip to content

http2: fix req.hostname not set#2113

Merged
mcollina merged 2 commits intofastify:masterfrom
mohd-akram:fix-http2-hostname
Feb 24, 2020
Merged

http2: fix req.hostname not set#2113
mcollina merged 2 commits intofastify:masterfrom
mohd-akram:fix-http2-hostname

Conversation

@mohd-akram
Copy link
Copy Markdown
Contributor

Fixes #2112

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • commit message and code follows Code of conduct

Copy link
Copy Markdown
Contributor

@SerayaEryn SerayaEryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread lib/route.js Outdated
Co-Authored-By: Matteo Collina <matteo.collina@gmail.com>
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Issue or PR that should land as semver patch v2.x Issue or pr related to Fastify v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request.hostname isn't set when using HTTP2

4 participants