fix: deduplicate NoteBookmark.Domain in coverage report (#113)#114
Merged
fix: deduplicate NoteBookmark.Domain in coverage report (#113)#114
Conversation
Tags are stored as comma-separated strings (e.g. "ai, agent, skill") but GetAllUniqueTags() was splitting on '.' so each full tag string landed in the HashSet unsplit, causing repeated prefixes like "ai" in the output. Also updates the existing test to use comma-separated tags (matching real data) and adds a regression test for the exact duplication scenario from the bug report. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…ookmark.Domain - Add ReportGenerator step to merge multiple cobertura.xml files - Feed deduplicated summary to CodeCoverageSummary action - Fixes duplicate NoteBookmark.Domain entries in coverage report (#113)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add ReportGenerator step to merge coverage reports from multiple test projects before feeding to CodeCoverageSummary. This fixes the duplicate
NoteBookmark.Domainentries in the coverage report.Problem
Two test projects reference
NoteBookmark.Domain:NoteBookmark.Api.TestsNoteBookmark.AIServices.TestsWhen
irongut/[email protected]parses multiple Cobertura XML files, it creates separate (and sometimes stale) entries for the same assembly, resulting in:Solution
Test plan
NoteBookmark.Domainonly onceCloses #113