Skip to content

[WIP] Add hero image for social preview in blog posts#6379

Merged
franciscojavierarceo merged 3 commits intomasterfrom
copilot/add-hero-image-for-social-preview
May 7, 2026
Merged

[WIP] Add hero image for social preview in blog posts#6379
franciscojavierarceo merged 3 commits intomasterfrom
copilot/add-hero-image-for-social-preview

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

  • Inspect current social metadata handling in infra/website for blog pages and identify hero-image frontmatter usage
  • Run existing website tests/lint checks to capture baseline status before code changes
  • Implement minimal change so blog pages use hero image for social preview when available, with existing Feast default as fallback
  • Add/update focused tests for blog social metadata behavior
  • Run targeted tests and manual verification (including screenshot of UI impact) and finalize

Copilot AI and others added 2 commits May 7, 2026 13:51
Agent-Logs-Url: https://github.com/feast-dev/feast/sessions/8c33bcc6-0cd4-4222-95a1-bfa02f136b5b

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/feast-dev/feast/sessions/8c33bcc6-0cd4-4222-95a1-bfa02f136b5b

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
@franciscojavierarceo franciscojavierarceo marked this pull request as ready for review May 7, 2026 13:53
@franciscojavierarceo franciscojavierarceo requested a review from a team as a code owner May 7, 2026 13:53
@franciscojavierarceo franciscojavierarceo merged commit bedc0ef into master May 7, 2026
27 of 28 checks passed
Copilot stopped work on behalf of franciscojavierarceo due to an error May 7, 2026 13:54
Copilot AI requested a review from franciscojavierarceo May 7, 2026 13:54
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2dd6f9e8b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +38 to 41
<meta property="og:image" content={socialImage}>
<meta property="og:image:width" content="1201">
<meta property="og:image:height" content="630">
<meta property="og:image:type" content="image/png">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep OG image metadata consistent with selected image

Now that og:image is dynamic on blog pages, these structured tags stay hard-coded to the default PNG dimensions/type, so posts whose hero image is JPEG/WEBP (e.g., several files under infra/website/docs/blog) publish contradictory metadata. Social crawlers can use these fields for validation/layout, so mismatches can lead to dropped or incorrectly rendered previews for affected posts; either compute these values per image or omit the structured fields when they are not accurate.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you fix this in another PR?

jyejare pushed a commit to opendatahub-io/feast that referenced this pull request May 8, 2026
* fix: Update go-feature-server base image to Go 1.25 and fix operator Dockerfile COPY permissions

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

* fix: Allow to publish from reference branch

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

* docs: Blog Post for MongoDB integration (feast-dev#6375)

* fix: Fix mongodb blog title

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

* fix: Fixed formatting and image for mongo blog (feast-dev#6377)

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

* [WIP] Add hero image for social preview in blog posts (feast-dev#6379)

* Initial plan

* fix: use blog hero image for social preview metadata

Agent-Logs-Url: https://github.com/feast-dev/feast/sessions/8c33bcc6-0cd4-4222-95a1-bfa02f136b5b

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

* fix: harden hero image extraction for blog social tags

Agent-Logs-Url: https://github.com/feast-dev/feast/sessions/8c33bcc6-0cd4-4222-95a1-bfa02f136b5b

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

* feat: Support non-string map key types (feast-dev#6382) (feast-dev#6383)

---------

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
Co-authored-by: bisht2050 <108942387+bisht2050@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: nquinn408 <57655411+nquinn408@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blog post should use hero image for social preview when available

2 participants