Non-string and non-numeric params in query

[Mangatt]

Hi guys,
when I try filter results of query with any non-numeric or non-string value (null, undefined or new Date()) I've got error. Are there any plans for adding support for these, so following would work?

• hook.params.query.date = null
• hook.params.query.date = undefined
• hook.params.query.date = new Date()

After some research I've found that advanced criteria work just fine:

• hook.params.query.date = {$in: [null]}
• hook.params.query.date = {$in: [new Date()]}

[daffl]

This depends on the database. We might want to add some service tests for those cases. Since you seem to be using MongoDB for now you can also use the $eq operator.

[Mangatt]

It's RethinkDB actually.

[ekryski]

Related to feathersjs-ecosystem/feathers-mongoose#122. @eddyystop possibly we can check for these types as well and coerce them from the querystring into their actual datatypes.

[daffl]

That might be tricky (and cause potentially unwanted conversions) without a schema definition for what we are querying.

[eddyystop]

Perhaps an optional hook.params.sanitizeQuery could indicate what to do. Primitive but ...

[ekryski]

@daffl that was my thought as well. If it was a hook that is documented you would be aware of the consequences and could optionally use it or not. I was thinking the coercion might just be for:

• booleans
• null
• ints

but you are right might be better to couple with some sort of schema definition for normalization/validation.

[daffl]

This specific problem for RethinkDB should be fixed via feathersjs-ecosystem/feathers-rethinkdb#53 (v0.3.0) now.

Closing since I don't think we can do too much for the more general case (without separate schema definitions).

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.