Hooks do not apply for realtime events

[Mangatt]

Hi,
I've just found that hooks do not apply for realtime events. Following code will remove password field from service response.

app.service('users').after({ all: hooks.remove('password'), });

But when entry is updated, whole entry is emmited through updated event, even with password field.

Are there any plans for unifiying filters for both service methods and realtime events or is there any workaround?

[marshallswain]

Hi @Mangatt, can you post your initial server setup? Hooks should work universally across all providers. Maybe there's a problem with the order you're initializing the plugins.

[daffl]

This used to be issue #248 which was fixed a while ago via feathersjs-ecosystem/feathers-hooks#57 (test in https://github.com/feathersjs/feathers-hooks/blob/c0a13f1c7b05135d9b67627c3c60c0965ac71b17/test/hooks.test.js#L47).

Are you using feathers-hooks 1.4.0 or later?

[Mangatt]

I'm using feathers-hooks 1.5.4. My setup is:

const app = feathers();

app.configure(configuration(__dirname, '../config'))
.use('/', serveStatic(app.get('public')))
.configure(rest())
.configure(socketio())
.configure(hooks())
.use(bodyParser.json())
.use(bodyParser.urlencoded({ extended: true }))
.configure(auth(app.get('auth')))
.configure(users)
.configure(locations)
.configure(messages);

app.use('/users', service({
Model: rethink,
name: 'users'
}));

app.service('users').after({
all: hooks.remove('password'),
});

Can you see a problem there?

[marshallswain]

Can you try moving hooks first, before the providers.

[Mangatt]

Even with changed order problem persists:

app.configure(configuration(__dirname, '../config'))
.use('/', serveStatic(app.get('public')))
.configure(hooks())
.configure(rest())
.configure(socketio())
.use(bodyParser.json())
.use(bodyParser.urlencoded({ extended: true }))
.configure(auth(app.get('auth')))
.configure(users)
.configure(locations)
.configure(messages);

[daffl]

One thing to note is that the standard remove hook will only run for external calls so events from internal calls to the service will be dispatched with the full data. One way to solve the issue is to add an event filter that always removes the data:

const omit = require('lodash.omit');

app.service('users').filter(data => omit(data, 'password'));

It might be a good idea to make the hooks where it applies (like remove) to also run as the correct event filters.

[Mangatt]

That would be great. Filtering at two places create unnecessary margin for errors.

[daffl]

Right now there is not really a way around that. We can't always remove the password since then we can't compare it.

What I meant was being able to do something like app.service('users').filter(hooks.remove('password'));

[daffl]

I keep wondering what would be a good way to solve this (not having to duplicate filters and hooks). Filters are very similar to hooks (feathersjs-ecosystem/transport-commons#4 is related) but I think only a few hooks also apply to filters.

@ekryski and I were talking about that events and event filtering could even be applied as a hook. That way hooks that conditionally run (like pluck, disable could run either way and add the result to the hook object which will then be dispatched by the filter).

[ekryski]

💯 @daffl having the event dispatch and filtering happen as the last hooks in the hook chain I think would solve this. We would no longer need filters and then you can be gauranteed that the state of your hook is what gets sent to your dispatcher.

[marshallswain]

That sounds good. That will make it so you opt in to events by needing to add a handler at the end.