Skip to content

Prefer const over let #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feross merged 1 commit into from
Dec 18, 2018
Merged

Prefer const over let #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions static/service-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
// Incrementing CACHE_VERSION will kick off the install event and force previously cached
// resources to be cached again.
const CACHE_VERSION = 1
let CURRENT_CACHES = {
const CURRENT_CACHES = {
offline: 'offline-v' + CACHE_VERSION
}
const OFFLINE_URL = 'offline.html'

function createCacheBustedRequest (url) {
let request = new Request(url, { cache: 'reload' })
const request = new Request(url, { cache: 'reload' })
// See https://fetch.spec.whatwg.org/#concept-request-mode
// This is not yet supported in Chrome as of M48, so we need to explicitly check to see
// if the cache: 'reload' option had any effect.
Expand All @@ -20,7 +20,7 @@ function createCacheBustedRequest (url) {
}

// If {cache: 'reload'} didn't have any effect, append a cache-busting URL parameter instead.
let bustedUrl = new URL(url, self.location.href)
const bustedUrl = new URL(url, self.location.href)
bustedUrl.search += (bustedUrl.search ? '&' : '') + 'cachebust=' + Date.now()
return new Request(bustedUrl)
}
Expand All @@ -41,7 +41,7 @@ self.addEventListener('activate', event => {
// Delete all caches that aren't named in CURRENT_CACHES.
// While there is only one cache in this example, the same logic will handle the case where
// there are multiple versioned caches.
let expectedCacheNames = Object.keys(CURRENT_CACHES).map(function (key) {
const expectedCacheNames = Object.keys(CURRENT_CACHES).map(function (key) {
return CURRENT_CACHES[key]
})

Expand Down
⚡