Added copyPasteProps helper#75
Open
gavinmcfarland wants to merge 3 commits intofigma-plugin-helper-functions:masterfrom
Open
Added copyPasteProps helper#75gavinmcfarland wants to merge 3 commits intofigma-plugin-helper-functions:masterfrom
gavinmcfarland wants to merge 3 commits intofigma-plugin-helper-functions:masterfrom
Conversation
Author
|
I've been using this helper in my own project. I believe there are still.some edge cases that may need to be covered. For example what happens when properties with mixed values are copied and pasted. Also we should consider that the default behaviour is. I have thoughts about whether is should (or should not) copy properties like the name by default. Should it match the same as the copy and paste ability in the editor? These are some things for us to consider. |
alexandrtovmach
approved these changes
Apr 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I created this function based on the clone function which only copies compatible properties between nodes. It's explicit in properties which are allowed, so it is safer. It also has an option to exclude and include specific properties.
Feel free to make suggestions to modify the actual function, maybe there is a DRYer way to write the function itself.