Correct issue in appd details field's schema, error in example and improve test#1034
Merged
kriswest merged 2 commits intofinos:masterfrom Jul 25, 2023
Merged
Conversation
…prove test - the details field of the appD schema is using `oneOf` to combine subschemas, however, this requires them to be distinct and non-verlapping. This should be `anyOf` instead as this prevents validation errors when the element conforms to multiple subschemas. - commas were removed from email fields in the fdc3-workbench example as these fail validation - The test was improved by adding multiple examples and providing better output from it.
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
Fixed my issue! 👍 |
hughtroeger
approved these changes
Jul 24, 2023
14 tasks
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1033
oneOfto combine subschemasurlproperty).anyOfshould be used in this situation instead asoneOfreturns validation errors when the element conforms to multiple subschemas.