Refine the varying schemas for ImplementationMetadata#1177
Merged
Conversation
…nnection step 3, step 6 and the API schemas
kriswest
added
api
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kriswest
changed the title
11 tasks
hughtroeger
approved these changes
Apr 3, 2024
Co-authored-by: Hugh Troeger <htroeger@factset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1057
There are several variations on the
ImplementationMetadata schema (in the API it hasAppMetadata, in bridging connection step 6 connectedAgentsUpdate its got the name assigned to each agent by the bridge, in connection step 3 it has neither). This PR ensures that the definitions generated for each type are correct. ThedesktopAgentname was previously missing from the connectedAgentsUpdate, which is a problem it doesn't match what is described in the specification