Skip to content

PrivateChannelEvent extends ApiEvent #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kriswest merged 2 commits into from
Dec 16, 2024
Merged

PrivateChannelEvent extends ApiEvent #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8607da0
PrivateChannelEvent extends ApiEvent
kriswest Dec 16, 2024
c0e1762
Changelog
kriswest Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* Added missing `resultType` argument to `findIntentByContext` agent request in the Bridging Schema. ([#1212](https://github.com/finos/FDC3/pull/1212))
* Added missing id and name fields from the context base schema to respective context schemas (`Contact`, `ContactList`, `Country`, `InstrumentList`, `OrderList`, `Organization`, `Portfolio`, `Position`, `TradeList`). ([#1360](https://github.com/finos/FDC3/pull/1360))
* Revised FDC3 charter to include well-known language from the FDC3 introduction, better describe FDC3's scope, focus on financial applications, update application types, etc. ([#1079](https://github.com/finos/FDC3/pull/1079))
* Ensured that `PrivateChannelEvent` extends `ApiEvent` in both sourcecode and documentation. ([#1474](https://github.com/finos/FDC3/pull/1474))

## [npm v2.1.1] - 2024-06-28

Expand Down
2 changes: 1 addition & 1 deletion src/api/Events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export type PrivateChannelEventTypes = "addContextListener" | "unsubscribe" | "d
* Type defining the format of event objects that may be received
* via a PrivateChannel's `addEventListener` function.
*/
export interface PrivateChannelEvent {
export interface PrivateChannelEvent extends ApiEvent{
readonly type: PrivateChannelEventTypes;
readonly details: any;
}
Expand Down
⚡