Skip to content

fix: better support 1.2 DAs by not requiring appMetadata in getInfo responses #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kriswest merged 11 commits into from
Apr 4, 2025
Merged

fix: better support 1.2 DAs by not requiring appMetadata in getInfo responses #1550

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
680c7d8
fix: better support 1.2 DAs by not requiring appMetadata in getInfo r…
kriswest Mar 26, 2025
d4da191
Update CHANGELOG.md
kriswest Mar 26, 2025
2d0ef1a
fix: correct URLs to context schema in FDC3 workbench
kriswest Mar 27, 2025
5a88ed6
fix: backwards compatibility for 1.2 in fdc3-workbench's channel store
kriswest Mar 27, 2025
6834353
Merge branch 'main' into 1549-workbench-stopped-working-in-1.2
kriswest Apr 4, 2025
40e61e9
Reset default for dontSetWindowFdc3 to correct value
kriswest Apr 4, 2025
a7024c7
Bind this for all DestkopAgentProxy functions to enable destructuring
kriswest Apr 4, 2025
8d3572e
Introduced function so that you can test getAgent parameters.
robmoffat Apr 4, 2025
a4a14b3
Polyfill node apis in workbench
kriswest Apr 4, 2025
9a2de9b
Merge branch '1549-workbench-stopped-working-in-1.2' of https://githu…
kriswest Apr 4, 2025
ed2470d
Update CHANGELOG.md
kriswest Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* Revised FDC3 charter to include well-known language from the FDC3 introduction, better describe FDC3's scope, focus on financial applications, update application types, etc. ([#1079](https://github.com/finos/FDC3/pull/1079))
* Ensured that `PrivateChannelEvent` extends `ApiEvent` in both sourcecode and documentation. ([#1474](https://github.com/finos/FDC3/pull/1474))
* Standardized prettier config for fdc3-workbench with other packages. ([#1520](https://github.com/finos/FDC3/pull/1520))
* Ensured that the FDC3 Workbench and apps like it that are migrated to getAgent will still work with FDC3 1.2 Preload-based DAs by not requiring appMetadata properties to be present in getInfo() responses. ([#1550](https://github.com/finos/FDC3/pull/1550))

## [npm v2.1.1] - 2024-06-28

Expand Down
6 changes: 3 additions & 3 deletions packages/fdc3-get-agent/src/strategies/DesktopAgentPreloadLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ export class DesktopAgentPreloadLoader implements Loader {
agentType: WebDesktopAgentType.Preload,
identityUrl: globalThis.window.location.href,
actualUrl: globalThis.window.location.href,
appId: implMetadata.appMetadata.appId,
instanceId: implMetadata.appMetadata.instanceId ?? 'unknown',
instanceUuid: implMetadata.appMetadata.instanceId ?? 'unknown', // preload DAs don't issue these so repeat the instanceId
appId: implMetadata?.appMetadata?.appId ?? 'unknown',
instanceId: implMetadata?.appMetadata?.instanceId ?? 'unknown',
instanceUuid: implMetadata?.appMetadata?.instanceId ?? 'unknown', // preload DAs don't issue these so repeat the instanceId
},
};

Expand Down
Loading
⚡