Add Natwest Group and its application details.#1709
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/easycla |
kriswest
left a comment
There was a problem hiding this comment.
Logo addition looks good to me under both adoptors and app providers:
https://deploy-preview-1709.preview-fdc3.finos.org/community
Can I get another approval from @finos/fdc3-maintainers or @robmoffat please?
kriswest
left a comment
There was a problem hiding this comment.
Still LGTM (after switching an image to .png format)
There was a problem hiding this comment.
Pull request overview
Adds NatWest Group (as an adopter) and Agile Markets (as an application provider) to the FDC3 website’s community/user listings, along with a new Agile Markets logo.
Changes:
- Add NatWest Group to
website/data/users.json(pinned member entry). - Add NatWest Group + Agile Markets entries to
website/data/community.json. - Add
AgileMarkets.pnglogo asset.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
website/static/img/users/AgileMarkets.png |
Adds the Agile Markets logo used by the new community entry. |
website/data/users.json |
Adds NatWest Group to the users list (caption/image/link metadata). |
website/data/community.json |
Adds NatWest Group (adopter) and Agile Markets (application-provider) entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6cdfddc
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2da9a88 to
08c87b6
Compare
kriswest
left a comment
There was a problem hiding this comment.
All suggested changes were applied. LGTM
Describe your change
Add Natwest Group and its applications information in FDC3 FINOS community page as adopters of FDC3 and as application providers (Agile Markets).
Contributor License Agreement
Review Checklist
DesktopAgent,Channel,PrivateChannel,Listener,Bridging)?JSDoc comments on interfaces and types should be matched to the main documentation in /docs
Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
npm run build) run and the results checked in?Generated code will be found at
/src/api/BrowserTypes.tsand/or/src/bridging/BridgingTypes.tsBaseContextschema applied viaallOf(as it is in existing types)?titleanddescriptionprovided for all properties defined in the schema?npm run build) run and the results checked in?Generated code will be found at
/src/context/ContextTypes.ts