Add missing contexts to ContextTypes enum and TS type#1796
Merged
Conversation
✅ Deploy Preview for fdc3 canceled.
|
Contributor
Author
|
will add a changelog entry... |
|
|
kriswest
changed the title
|
|
Contributor
Author
|
I'm pretty sure we're double counting tests somehow - I added 2 and the count went up 4 |
Roaders
approved these changes
Mar 18, 2026
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
fdc3-standard contains a ContextTypes.ts file which can be used to validate context type names. However, it is out of sync with the fdc3-contexts package. This PR adds the missing types in and implements tests that will prevent that from happening again.
I'd like to include this in 2.2.2 release as a correction.
Contributor License Agreement
Review Checklist