chore: switch SAST from semgrep to CodeQL and update Node workflows t…#1868
Open
Mankurj05 wants to merge 2 commits intofinos:mainfrom
Open
chore: switch SAST from semgrep to CodeQL and update Node workflows t…#1868Mankurj05 wants to merge 2 commits intofinos:mainfrom
Mankurj05 wants to merge 2 commits intofinos:mainfrom
Conversation
…o v24 - Replace semgrep workflow with CodeQL static analysis (github/codeql-action) to align with OpenSSF Scorecard recognition requirement (issue finos#1827) - Update CI workflows from Node 20 (EOL) to Node 24 (current LTS): - coverage.yml: Node 20.x to 24.x - release.yml: Node 20 to 24 (all three jobs) - cve-scanning.yml: simplify to single Node 24 (removes matrix) - Add Node engine constraint (>=22) to root package.json per maintainer guidance indicating support floor and future Node 25 capability (issue finos#1826) Closes finos#1827 finos#1826
✅ Deploy Preview for fdc3 canceled.
|
e70e5a4 to
5ef5c34
Compare
Author
|
This PR only updates CI/SAST workflows and Node engine support metadata; no FDC3 API, schema, context-type, intent, or docs changes. |
Author
|
Rebased onto latest main and fixed a stray release workflow conflict from the rebase. The branch should be clean now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o v24
Closes #1827 #1826
Describe your change
Related Issue
Contributor License Agreement
Review Checklist
DesktopAgent,Channel,PrivateChannel,Listener,Bridging)?JSDoc comments on interfaces and types should be matched to the main documentation in /docs
Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
npm run build) run and the results checked in?Generated code will be found at
/src/api/BrowserTypes.tsand/or/src/bridging/BridgingTypes.tsBaseContextschema applied viaallOf(as it is in existing types)?titleanddescriptionprovided for all properties defined in the schema?npm run build) run and the results checked in?Generated code will be found at
/src/context/ContextTypes.ts