Skip to content

362 All DesktopAgent and Channel APIs are async#516

Merged
rikoe merged 3 commits intofinos:masterfrom
InteropIO:362-DesktopAgent-and-Channel-APIs-should-be-async
Dec 21, 2021
Merged

362 All DesktopAgent and Channel APIs are async#516
rikoe merged 3 commits intofinos:masterfrom
InteropIO:362-DesktopAgent-and-Channel-APIs-should-be-async

Conversation

@kriswest
Copy link
Copy Markdown
Contributor

@kriswest kriswest commented Nov 26, 2021

resolves #362

  • Updates the following functions to be async (all return promises):
    • fdc3.broadcast & channel.broadcast
    • fdc3.addIntentListener
    • fdc3.addContextListener & channel.addContextListener
    • fdc3.getInfo
  • Updated documentation and examples
  • Updates method.ts and associated tests

@kriswest kriswest requested review from a team, ggeorgievx, mattjamieson and rikoe November 26, 2021 18:36
@kriswest kriswest changed the title All DesktopAgent and Channel APIs are async 362 All DesktopAgent and Channel APIs are async Nov 26, 2021
@kriswest kriswest added api FDC3 API Working Group channels feeds & transactions Channels, Feeds & Transactions Discussion Group labels Nov 26, 2021
@kriswest kriswest mentioned this pull request Nov 30, 2021
Closed
11 tasks
mattjamieson
mattjamieson approved these changes Dec 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rikoe rikoe merged commit 0ece665 into finos:master Dec 21, 2021
@kriswest kriswest deleted the 362-DesktopAgent-and-Channel-APIs-should-be-async branch February 4, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattjamieson mattjamieson mattjamieson approved these changes

@rikoe rikoe Awaiting requested review from rikoe

@ggeorgievx ggeorgievx Awaiting requested review from ggeorgievx

Assignees

No one assigned

Labels

api FDC3 API Working Group channels feeds & transactions Channels, Feeds & Transactions Discussion Group cla-present

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

All DesktopAgent and Channel APIs should be async

3 participants

@kriswest @mattjamieson @rikoe
⚡