590 intent proposal start email#632
Merged
mistryvinay merged 4 commits intofinos:context-data-and-intents-consolidated-update-branchfrom May 23, 2022
Conversation
15 tasks
hughtroeger
approved these changes
Apr 22, 2022
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
24 tasks
Contributor
|
@finos/fdc3-maintainers any blockers stopping this from being approved? |
kriswest
requested changes
May 10, 2022
| | `recipients` | fdc3.contact or fdc3.contactList | Yes | { type: "fdc3.contact", name: "John Doe", id: { "email": "john@sample.com"}} | | ||
| | `subject` | string | No | `'The information you requested'` | | ||
| | `textBody` | string | No | `'Blah, blah, bah` | | ||
| | `richTextBody` | fdc3.richTextBlock | No | See https://github.com/finos/FDC3/issues/575 | |
Contributor
There was a problem hiding this comment.
Needs updating if that issue/PR is merged, or removing if not...
Contributor
Author
There was a problem hiding this comment.
I'm not sure what the request is here
Contributor
There was a problem hiding this comment.
@pauldyson It was mostly to remind me to make sure this is sorted before we merge.
This PR refers to issue #575 - we, need to resolve that reference before we release if #575 has a PR that gets merged (which has not been raised yet - correct me if I'm wrong on that @bertrand-s) or remove this/downgrade to a note that it might be added in future.
29 tasks
Co-authored-by: Kris West <kris@cosaic.io>
✅ Deploy Preview for lambent-kulfi-cf51a7 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Co-authored-by: Kris West <kris@cosaic.io>
mistryvinay
changed the base branch from
master
to
context-data-and-intents-consolidated-update-branch
mistryvinay
added a commit
that referenced
this pull request
May 23, 2022
…o context-data-and-intents-consolidated-update-branch Merge of PR #632. Removed richTextBody reference.
mistryvinay
merged commit 7ff1c18
into
finos:context-data-and-intents-consolidated-update-branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the email context-related updates carefully as it is my first go at this so
I've made detailed notes on all the context-related updates and will submit a 'how-to guide" once this PR has been signed off
resolves #590