588 intent proposal ViewOrders#672
Merged
mistryvinay merged 1 commit intofinos:context-data-and-intents-consolidated-update-branchfrom May 23, 2022
Merged
Conversation
kriswest
added
Context Data & Intents
hughtroeger
approved these changes
Apr 22, 2022
kriswest
approved these changes
May 11, 2022
Contributor
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
LGTM - needs a CHANGELOG.md entry
29 tasks
mistryvinay
changed the base branch from
master
to
context-data-and-intents-consolidated-update-branch
mistryvinay
added a commit
that referenced
this pull request
May 23, 2022
…-data-and-intents-consolidated-update-branch Merging PR #672 into consolidated PR branch
mistryvinay
merged commit fb6d4f6
into
finos:context-data-and-intents-consolidated-update-branch
mistryvinay
reviewed
May 23, 2022
Contributor
mistryvinay
left a comment
mistryvinay
left a comment
There was a problem hiding this comment.
Looks good to me. Added CHANGELOG.md entry as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #588