Skip to content

Valuation schema update due to a misspelling#834

Merged
kriswest merged 3 commits intomasterfrom
833-fdc3valuation-has-incorrect-country_iscode
Oct 25, 2022
Merged

Valuation schema update due to a misspelling#834
kriswest merged 3 commits intomasterfrom
833-fdc3valuation-has-incorrect-country_iscode

Conversation

@mistryvinay
Copy link
Copy Markdown
Contributor

Resolves issue #833

@mistryvinay mistryvinay added bug Something isn't working context-data FDC3 Context Data Working Group labels Oct 17, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 17, 2022

Deploy Preview for lambent-kulfi-cf51a7 ready!

Name Link
🔨 Latest commit f30b08e
🔍 Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/6357ec340039260008f8c5a6
😎 Deploy Preview https://deploy-preview-834--lambent-kulfi-cf51a7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mistryvinay mistryvinay linked an issue Oct 17, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@openfin-johans openfin-johans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

fix typo in 2.0 version of schema
Copy link
Copy Markdown
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit to also fix in 2.0 schemas. LGTM

@kriswest kriswest merged commit 5631b9c into master Oct 25, 2022
@kriswest kriswest mentioned this pull request Oct 25, 2022
32 tasks
@kriswest kriswest deleted the 833-fdc3valuation-has-incorrect-country_iscode branch November 10, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working context-data FDC3 Context Data Working Group

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fdc3.valuation has incorrect COUNTRY_ISCODE member

3 participants