Clarify docs and comments on Errors and and findIntent error response#843
Merged
Clarify docs and comments on Errors and and findIntent error response#843
Conversation
…ts - also syncing Channel source code comments to docs
✅ Deploy Preview for lambent-kulfi-cf51a7 canceled.
|
32 tasks
hughtroeger
approved these changes
Nov 3, 2022
mattjamieson
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #807
resolves #841
Clarifies how errors should be returned (reject promise with JS Error object, using message from enumeration) throughout docs and source comments in 2.0. Includes clarification that
findIntentfns should error if no apps are found