updating definition of otherConfig in fdc3.chart to use an array of context objects

[kriswest]

resolves #856

Changes the definition of otherConfig in fdc3.chart from an unstandardized object to an array of Context objects. This allows the type of each additional piece of config to be checked and either used or ignored by a charting application, based on its type.

@rbruckheimer

[netlify]

✅ Deploy Preview for fdc3 canceled.

Name	Link
🔨 Latest commit	3a43bba
🔍 Latest deploy log	https://app.netlify.com/sites/fdc3/deploys/64625244ec96510008a61a54

[rbruckheimer]

Is there a concern for backwards compatibility here?

[kriswest]

@rbruckheimer AFAIK ChartIQ is the main user of this type (although my information on that is not perfect), so you'd know better than I. Do you have clients using it currently?

I wouldn't propose a change like this for an element that was standardized, however, this field was specifically for unstandardized data. A backwards-compatible change, that also doesn't have a redundant layer would be to use an object and create fields under it which are arrays, but divide them up by type, e.g. indicators, drawings, formulae, other (so that they have a purpose in organizing the config). OR you could keep otherConfig as a deprecated field and create a proprietaryConfig or customConfig field to supercede it. OR just live with that redundancy (otherConfig.config).

Writing it out, seems like either the breaking change or deprecation and creating a new field seem like the best options.

Let me know what you prefer and I can adjust the PR.

[rbruckheimer]

Let's go with your proposal and we can change accordingly.

[kriswest]

@mistryvinay this should be ready for your review and merge into your consolidated update branch for Context and Intents

[kriswest]

@mistryvinay actually looks like I've got small git snafu after changing the base, will fix.

[kriswest]

fixed and good to go @mistryvinay.
Needs @greyseer256's blessing too.

[mistryvinay]

LGTM

[kriswest]

@greyseer256 please check this one when you have a second, so we can merge into the consolidated Context & Intents branch for 2.1