Refactor CLI and shared tests to use vitest#1073
Merged
rocketstack-matt merged 5 commits intofinos:mainfrom Mar 27, 2025
Merged
Refactor CLI and shared tests to use vitest#1073rocketstack-matt merged 5 commits intofinos:mainfrom
rocketstack-matt merged 5 commits intofinos:mainfrom
Conversation
willosborne
requested review from
a team,
Thels,
aidanm3341,
grahampacker-ms,
jpgough-ms,
lbulanti-ms and
rocketstack-matt
as code owners
willosborne
force-pushed
the
vitest-refactor
branch
from
c959567 to
c51148c
Compare
Seperate cli setup for ease of testing + add code coverage with vi (finos#1075)
rocketstack-matt
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jest tests are very janky with Typescript. The result is that we can't run any tests from the VSCode test runner extensions.
This refactors all the tests to use vitest (currently used by the calmhub UI) that is Typescript-native.
This makes the config a lot simpler and also massively faster, since there's no transpile step before the tests get run.
This has a small issue where for some reason, a very small number of tests in the project don't seem to find the 'vi' module because the vitest globals aren't picked up. It might be my editor setup, too. This doesn't break any tests but is annoying - will see if I can fix later.