Fix global install issues with cli (#1043)#1077
Merged
LeighFinegold merged 2 commits intofinos:mainfrom Mar 27, 2025
Merged
Conversation
LeighFinegold
requested review from
a team,
Thels,
aidanm3341,
grahampacker-ms,
jpgough-ms,
lbulanti-ms,
rocketstack-matt and
willosborne
as code owners
aidanm3341
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following issue fixes issue1 with tsnode and json-ref-parser libraries not being installed as part of the calm cli (a pre-requisite for the
calm templateendpointThe cli.e2e.spec.ts now leverages npm pack to simulate the actual package that npm publishes and simulates a consumer installing calm from npm in an isolated node environment. Going forward this test now gives full confidence on cli endpoints.