Remediate issue with calm docify on 0.6.0 release#1082
Merged
Thels merged 3 commits intofinos:mainfrom Mar 28, 2025
Merged
Conversation
LeighFinegold
requested review from
a team,
Thels,
aidanm3341,
grahampacker-ms,
jpgough-ms,
lbulanti-ms,
rocketstack-matt and
willosborne
as code owners
LeighFinegold
changed the title
Thels
force-pushed
the
esm_integration_docify_endpoint
branch
from
b197640 to
6765b0a
Compare
Thels
approved these changes
Mar 28, 2025
Member
Thels
left a comment
Thels
left a comment
There was a problem hiding this comment.
Spoken with @LeighFinegold at length, as well as reviewing the changes locally in VSCode on Windows. These changes are built upon what @aidanm3341 and myself did on Wednesday.
I've asked @willosborne to include in the dev container or Flox setup for configuring ViTest extension so that it works natively out of the box. As a follow-up, but this is a great move away from CJS!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following issue contains foundational changes to move towards ESM.
It additionally fixes the current issue with the
calm docifyendpoint on the 0.6.0/0.6.1 release by bundling all the code needed for the DocusarusTransformer to work.