Follow refs when generating definitions#174
Merged
willosborne merged 14 commits intofinos:mainfrom Apr 29, 2024
Merged
Conversation
willosborne
requested review from
aidanm3341,
grahampacker-ms and
lbulanti-ms
as code owners
willosborne
commented
Apr 24, 2024
willosborne
force-pushed
the
generate-ref-lookup
branch
from
9e39849 to
0f3c2f1
Compare
willosborne
commented
Apr 26, 2024
lbulanti-ms
previously approved these changes
Apr 26, 2024
aidanm3341
requested changes
Apr 26, 2024
Member
|
@TheJuanAndOnly99 Semgrep action appears to be working on schedule but still failing to login on PR . . . is this just a limitation and something that can't be done (because PR action triggered from fork can't have access to secrets) or is there a project where this is working? |
aidanm3341
approved these changes
Apr 29, 2024
Member
aidanm3341
left a comment
aidanm3341
left a comment
There was a problem hiding this comment.
Will and I agreed to take some time later to try and improve the typing, but that we can still merge this PR in its current state. I'm happy with the changes
9 tasks
jpgough-ms
pushed a commit
that referenced
this pull request
May 6, 2026
…ide (#2422) The serialize-javascript ^7.0.5 override in package.json wasn't being applied to mocha's nested copy because the lockfile retained a stale node_modules/mocha/node_modules/serialize-javascript@6.0.2 entry from before the override was added. npm install preserves existing nested entries even when an override is added afterwards. Removing the stale lockfile entry lets npm re-resolve mocha's serialize-javascript dependency under the override; it now points at the hoisted top-level serialize-javascript@7.0.5. Resolves Dependabot alert #174 (GHSA-5c6j-r48x-rmvq, RCE in serialize-javascript via RegExp.flags / Date.prototype.toISOString).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #139 partially.
Now when a node, relationship or interface references a schema with $ref, it will be resolved and generated against a set of schemas loaded with a -s property.
Note this property is optional. For now it just skips lookups if this is not set - eventually will use the bundled metaschema.
Circular references are handled by simply terminating and returning the object as it is so far.
This does not instantiate refs from within nodes - e.g. if you define an object in your defs and simply reference it from a property this won't be followed. It's only definitions of nodes, interfaces and relationships. This will be added in a subsequent PR.